svn commit: r228785 - in head/sys/dev/ath/ath_hal: ar5210 ar5211

[Adrian Chadd]

On 22 December 2011 10:08, Alexander Best <arundel at freebsd.org> wrote:

>> You don't think changes should be reviewed (that's what I said above, I did
>> not necessarily say it should be reverted)?  That's way out in left field if
>> that is what you really think.
>
> no of course not. let's handle it this way:
>
> keep the commits and adrian@ and everybody else can test dim@'s
> changes. if the commits broke anything, they should be reverted.

Well, he's already reverted them. I've reviewed the HAL_TRUE -> HAL_OK
change, that's fine.
Nothing uses that particular bit of code in the HAL at the moment (and
if someone wants to support the payload compression code for the
AR5212 era devices, please let me know :)

I'll test out the shift register changes tonight and see if I can dig
up the AR5210/AR5211 datasheets internally. Once I've verified it's
right, I'll commit the change.

> the next time dim@ is about to touch non trivial code or code that is being
> maintained by a certain developer, he should post his patches to some
> mailinglist (-wireless@ in this case) and cc that particular developer
> (adrian@ in this case).

Yup. You guys already did that in November, so thankyou for that. I
just hadn't until recently found equipment to test it out.

> no hard feelings. ;)

Oh there's no hard feelings. None whatsoever. :-)

There, resolved! Time for a cool, refreshing glass of orange juice.

Adrian