svn commit: r228809 - vendor/openpam/dist/lib

[Dag-Erling Smørgrav]

Gleb Smirnoff <glebius at FreeBSD.org> writes:
> I haven't yet tested this, but code looks like it is not going to print
> anything in a case I don't have /usr/local/bin/pam_foo.so, while purpose
> of the patch is to avoid logging of failure to open
> /usr/local/bin/pam_foo.so.5.
>
> Although openpam_dynamic() will do some logging of errno value, the name
> of the failed file won't be logged. If I got a lot of modules configured,
> then I can't figure out which one is ENOENT.
>
> IMHO, some no_log flag should be passed down from the try_dlopen() to fix
> the issue correctly.

Index: openpam_dynamic.c
===================================================================
--- openpam_dynamic.c   (revision 509)
+++ openpam_dynamic.c   (working copy)
@@ -124,7 +124,7 @@
          dlclose(dlh);
          FREE(module);
 err:
-       openpam_log(PAM_LOG_ERROR, "%m");
+       openpam_log(PAM_LOG_ERROR, "%s: %m", path);
        return (NULL);
 }
 

DES
-- 
Dag-Erling Smørgrav - des at des.no