svn commit: r228790 - in head/usr.sbin: fwcontrol newsyslog ypserv

Doug Barton dougb at FreeBSD.org
Wed Dec 21 20:42:50 UTC 2011


On 12/21/2011 12:40 PM, Eitan Adler wrote:
> On Wed, Dec 21, 2011 at 3:39 PM, Doug Barton <dougb at freebsd.org> wrote:
>> A better way to write this commit log would be, "Remove null pointer
>> checks that are extraneous because ..."  2/3 why, 1/3 what.
> 
> Noted.

Thanks. However, I was perhaps too subtle in asking you to actually
explain why they were not needed.  :)

>>>   - Fix memory leak
>>
>> Should this perhaps have been a separate commit?
> 
> Probably. I'll be more careful next time.

Awesome!


Doug

-- 

		[^L]

	Breadth of IT experience, and depth of knowledge in the DNS.
	Yours for the right price.  :)  http://SupersetSolutions.com/



More information about the svn-src-all mailing list