svn commit: r228143 - in head: . share/mk tools/build/options

[Garrett Cooper]

On Mon, Dec 19, 2011 at 10:20 PM, Bruce Evans <brde at optusnet.com.au> wrote:
> On Mon, 19 Dec 2011, Warner Losh wrote:
>
>> On Nov 29, 2011, at 1:53 PM, Garrett Cooper wrote:
>>
>>> 2011/11/29 Doug Barton <dougb at freebsd.org>:
>>>>
>>>> On 11/29/2011 12:47, Gábor Kövesdán wrote:
>>>>>
>>>>> On 2011.11.29. 20:46, Max Khon wrote:
>>>>>>
>>>>>> Log:
>>>>>>   Turn off profiled libs build by default.
>>>>>>   Can be enabled back using WITH_PROFILE=yes in /etc/src.conf
>>>>>
>>>>> I think it was useful. Profiling is useful for developing any piece of
>>>>> software that builds on libc or other common libs, even for software
>>>>> that is not directly related to FreeBSD. I think it should be reverted.
>>>>
>>>>
>>>> Since we ask users to read -current, it would be useful if our
>>>> developers did too. :)
>>>>
>>>> As Max pointed out in his message about this, the profiled libs are only
>>>> really useful to a tiny percentage of developers. If you need them,
>>>> twist the knob. Building them should be off by default.
>>>
>>>
>>> +1. The needs of the many outweigh the needs of the few. As suggested
>>> elsewhere, I think it would also be a good idea to enable it in
>>> tinderbox builds.
>>
>>
>> -1.  The needs of the many?  Please.  Let's break a useful feature because
>> some people don't understand it and are impatient?  That's lame.
>
> Don't be silly.  Building profiled libraries takes as much as 1 minute.
> Many would not want to wait that long (if they noticed how long it takes).
> This is not 1994 when building of profiling libraries was left in because
> it only took an extra hour or or so.

    The assumption (that isn't clearly stated) is that I am building
things on suped up x86 hardware, not arm CPUs, Intel Atoms, etc. On
those platforms building superfluous things still do matter (in
particular because cross-building some things still isn't doable 100%
of the time, but also because flash, some platter media, etc is slow).
But I suppose I digress...
Thanks,
-Garrett