svn commit: r228650 - head/usr.bin/netstat

[Bjoern A. Zeeb]

On 17. Dec 2011, at 21:58 , Dimitry Andric wrote:

> On 2011-12-17 22:53, Bjoern A. Zeeb wrote:
>> 
>> On 17. Dec 2011, at 17:21 , Dimitry Andric wrote:
>> 
>>> Author: dim
>>> Date: Sat Dec 17 17:21:47 2011
>>> New Revision: 228650
>>> URL: http://svn.freebsd.org/changeset/base/228650
>>> 
>>> Log:
>>> In usr.bin/netstat/atalk.c, work around a clang false positive with
>>> printf format warnings and conditional operators.
>>> 
>> 
>> This does not sound like a good idea.  Make clang work.
> 
> It's already being worked on, see:
> 
>  http://lists.cs.uiuc.edu/pipermail/cfe-dev/2011-November/018464.html
> 
> and:
> 
>  http://llvm.org/bugs/show_bug.cgi?id=11313
> 
> Meanwhile, this is just a temporary workaround.  If you think it is too
> disruptive, I can just add NO_WFORMAT to the Makefile instead.

I'd prefer we do not start mangling source code for things that are
not a problem with the code and just a problem with the warning level.

Especially if the change will not be required anymore in the future.
A Makefile option we can easily identify and grep for, a cast we just
forget.

/bz

-- 
Bjoern A. Zeeb                                 You have to have visions!
         Stop bit received. Insert coin for new address family.