svn commit: r228625 - head/usr.bin/csup

Bjoern A. Zeeb bzeeb-lists at lists.zabbadoz.net
Sat Dec 17 21:56:24 UTC 2011


On 17. Dec 2011, at 21:54 , Dimitry Andric wrote:

> On 2011-12-17 22:32, mdf at FreeBSD.org wrote:
> ...
>>> In usr.bin/csup/auth.c, use the correct number of bytes for zeroing the
>>> shared secret, and use long long format to snprintf a time_t.
>> If casting is necessary, style prefers intmax_t or uintmax_t, since
>> those are always wide enough.
> 
> I don't see anything about that in style(9), maybe it should be added
> then?  In any case, I only changed the %ld format to %lld, because
> time_t is int, long or long long depending on arch.  Long long is just
> the widest type required in this case.

time_t is not always int.  See sparc64.

-- 
Bjoern A. Zeeb                                 You have to have visions!
         Stop bit received. Insert coin for new address family.



More information about the svn-src-all mailing list