svn commit: r228148 - head/sys/conf

[Garrett Cooper]

On Wed, Nov 30, 2011 at 4:59 PM, Alexander Best <arundel at freebsd.org> wrote:
> On Tue Nov 29 11, John Baldwin wrote:
>> Author: jhb
>> Date: Tue Nov 29 21:28:48 2011
>> New Revision: 228148
>> URL: http://svn.freebsd.org/changeset/base/228148
>>
>> Log:
>>   Remove a bit of debugging that accidentally crept in earlier.
>>
>> Modified:
>>   head/sys/conf/newvers.sh
>>
>> Modified: head/sys/conf/newvers.sh
>> ==============================================================================
>> --- head/sys/conf/newvers.sh  Tue Nov 29 20:06:27 2011        (r228147)
>> +++ head/sys/conf/newvers.sh  Tue Nov 29 21:28:48 2011        (r228148)
>> @@ -99,7 +99,6 @@ for dir in /bin /usr/bin /usr/local/bin;
>>  done
>>
>>  if [ -n "$svnversion" ] ; then
>> -     echo "$svnversion"
>>       svn=`cd ${SYSDIR} && $svnversion`
>
> any chance we could replace $svnversion with something like the following:
>
> 'svn info|grep ^Revision|sed 's/^Revision: //'' ?
>
> this is much faster and the only downside seems to be the missing {MSP} at the
> end.
>
> running a standard hdd, svnversion takes almost half a minute, while the
> command above finishes in < 0.1 seconds.

    We already hashed over that in the last discussion. svnversion was
picked because it iterates over the entire tree and you know for an
absolute fact that it's running versions X-Y-Z, instead of the version
of the Makefile being X.
Thanks,
-Garrett