svn commit: r220558 - in head/sys: arm/econa dev/usb/controller
nwhitehorn at freebsd.org
Tue Apr 12 13:04:27 UTC 2011
On 04/12/11 07:57, Hans Petter Selasky wrote:
> On Tuesday 12 April 2011 14:39:19 Nathan Whitehorn wrote:
>> On 04/12/11 02:49, Hans Petter Selasky wrote:
>>> Author: hselasky
>>> Date: Tue Apr 12 07:49:11 2011
>>> New Revision: 220558
>>> URL: http://svn.freebsd.org/changeset/base/220558
>>> We don't need to call EOWRITE4(sc, EHCI_USBINTR, 0) directly from each
>>> EHCI bus driver at detach, hence ehci_detach() does exactly this
>>> since r199718.
>> Just so you're aware, there's also another EHCI driver in the tree at
>> /sys/powerpc/ps3/ehci_ps3.c. It might also need some modifications at
>> various points when you're cleaning up EHCI drivers.
> This driver doesn't have a detach method. The patches don't apply to this
> driver then. Should I add a detach method or is it superfluous?
No, neither it nor the bus to which it is attached support detaching
devices (I was lazy when I wrote), so it's moot for this change. This
was just a heads-up for future cleanups.
More information about the svn-src-all