svn commit: r213164 - head/sys/geom/eli

Pawel Jakub Dawidek pjd at FreeBSD.org
Sat Sep 25 10:31:05 UTC 2010


Author: pjd
Date: Sat Sep 25 10:31:05 2010
New Revision: 213164
URL: http://svn.freebsd.org/changeset/base/213164

Log:
  Ignore errors from BIO_FLUSH. It might confuse users that provider wasn't
  really killed. What we really care about are write errors only.
  
  MFC after:	2 weeks

Modified:
  head/sys/geom/eli/g_eli_ctl.c

Modified: head/sys/geom/eli/g_eli_ctl.c
==============================================================================
--- head/sys/geom/eli/g_eli_ctl.c	Sat Sep 25 09:43:24 2010	(r213163)
+++ head/sys/geom/eli/g_eli_ctl.c	Sat Sep 25 10:31:05 2010	(r213164)
@@ -688,7 +688,7 @@ g_eli_ctl_delkey(struct gctl_req *req, s
 		 * Flush write cache so we don't overwrite data N times in cache
 		 * and only once on disk.
 		 */
-		g_io_flush(cp);
+		(void)g_io_flush(cp);
 	}
 	bzero(&md, sizeof(md));
 	bzero(sector, sizeof(sector));
@@ -739,13 +739,11 @@ g_eli_kill_one(struct g_eli_softc *sc)
 				if (error == 0)
 					error = err;
 			}
-			err = g_io_flush(cp);
-			if (err != 0) {
-				G_ELI_DEBUG(0, "Cannot flush %s (error=%d).",
-				    pp->name, err);
-				if (error == 0)
-					error = err;
-			}
+			/*
+			 * Flush write cache so we don't overwrite data N times
+			 * in cache and only once on disk.
+			 */
+			(void)g_io_flush(cp);
 		}
 		free(sector, M_ELI);
 	}


More information about the svn-src-all mailing list