svn commit: r212617 - head/sys/ufs/ffs

[Doug Barton]

On 9/16/2010 7:29 PM, Carlos A. M. dos Santos wrote:
> On Thu, Sep 16, 2010 at 5:44 AM, Brian Somers<brian at freebsd.org>  wrote:
>> If INVARIANTS is not defined, the above i++ will not happen.
>
> Which does not cause any harm, since "i" is a local variable, not used
> anywhere else in the function. A picky compiler would complain,
> however, that the variable is never read.

If 'i' is only ever used in the INVARIANTS case then it should be 
appropriately wrapped everywhere it appears. While the _current_ 
situation may be harmless, in the future lack of an appropriate 
indication of its use may cause a problem. This isn't just a pedantic 
concern, we had a case like this that broke the build just recently.


Doug

-- 

	... and that's just a little bit of history repeating.
			-- Propellerheads

	Improve the effectiveness of your Internet presence with
	a domain name makeover!    http://SupersetSolutions.com/