svn commit: r214144 - head/sys/vm
John Baldwin
jhb at freebsd.org
Thu Oct 21 18:41:32 UTC 2010
On Thursday, October 21, 2010 2:19:21 pm Ed Schouten wrote:
> Hi John,
>
> * John Baldwin <jhb at FreeBSD.org>, 20101021 19:29:
> > + if (atomic_fetchadd_int(&vm->vm_refcnt, -1) == 1)
> > vmspace_dofree(vm);
>
> Not that it's that useful, but maybe it would be good to use
> refcount_release() here?
Not in this case because the other places do not use the refcount API.
Specifically, the code in vmspace_exit() is a bit tortuous. I'd rather code
only use the refcount API if it is going to always use it.
--
John Baldwin
More information about the svn-src-all
mailing list