svn commit: r207790 - head/usr.bin/tar

Tim Kientzle kientzle at freebsd.org
Sat May 22 17:17:59 UTC 2010


Ah, yes.  I did forget to add an EINTR check to the write side.

Attached patch should fix "tar cf"

Thanks for your careful testing...


Anonymous wrote:
> Anonymous <swell.k at gmail.com> writes:
> 
>> Tim Kientzle <kientzle at freebsd.org> writes:
>>
>>> Please try the attached patch and let me know if it fixes it for you...
>>>
>>> Cheers,
>>>
>>> Tim
>> [...]
>>
>> It fixes the issue. Thanks.
> 
> I'm afraid not. Similar issue affects `tar cf - blah | tar xf -'.
> It's a little bit harder to reproduce. Caught after using pkg_add(1).
> 
>   # pkg_add gtk-2.20.1_1.tbz
>   load: 0.21  cmd: bsdtar 3351 [running] 0.06r 0.02u 0.00s 1% 6348k
>   In: 307200 bytes, compression 76%;  Out: 161 files, 1316787 bytes
>   Current: include/gtk-2.0/gtk/gtklabel.h (8627 bytes)
>   load: 0.16  cmd: bsdtar 3354 [tx->tx_quiesce_done_cv)] 4.08r 0.00u 0.14s 1% 2712k
>   In: 544 files, 36359168 bytes; Out: 36352000 bytes, compression 0%
>   Current: share/locale/hi/LC_MESSAGES/gtk20-properties.mo (131072/234342 bytes)
>   load: 0.16  cmd: bsdtar 3354 [tx->tx_quiesce_done_cv)] 4.86r 0.00u 0.14s 1% 2712k
>   tar: Write error
>   In: 36341760 bytes, compression 0%;  Out: 544 files, 36341760 bytes
>   Current: share/locale/hi/LC_MESSAGES/gtk20-properties.mo (234342 bytes)
>   share/locale/hi/LC_MESSAGES/gtk20-properties.mo: Truncated tar archive
>   tar: Error exit delayed from previous errors.
>   pkg_add: leave_playpen: can't chdir back to ''
>   zsh: exit 2     sudo -E pkg_add gtk-x11-2.20.1_1.tbz
> 
> Workaround is the same - svn diff -c207790 | patch -R
> 
> --
> I don't remember svn revision (newvers.sh doesn't work here). But it was
> after you committed that patch.
> 
>   $ uname -vm
>   FreeBSD 9.0-CURRENT #0: Fri May 21 15:32:05 UTC 2010 ...:.../PHOENIX  amd64
> 
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libarchive_write_handle_eintr.patch
Type: text/x-patch
Size: 3410 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/svn-src-all/attachments/20100522/e6a62b56/libarchive_write_handle_eintr.bin


More information about the svn-src-all mailing list