svn commit: r207472 - in head/sys: conf dev/ath/ath_hal/ar5212

[Daniel O'Connor]

On 02/05/2010, at 11:17 AM, M. Warner Losh wrote:
> : Could you do TUNABLE_INT in the MIPS code and TUNABLE_INT_FETCH in ath_hal?
> 
> How is that better than a kernel option?  The only place this would
> ever happen is atheros AR71xx SoC.  It isn't like some of the Atheros
> 71xx SoCs would have it and some wouldn't.

OK.

> And besides, kenv has to be compiled into the kernel on MIPS these
> days...

Ahh that makes a tunable fairly useless then :)

> The only thing close to an idea I've had is to add:
> 
> __weak int
> ath_needs_dma_war()
> {
> 	return 0;
> }
> 
> and have this in the mips:
> 
> int needs_ath_dma_war = 0;
> __weak int ath_needs_dma_war()
> {
> 	return needs_ath_dma_war;
> }
> 
> and set it to 1 in the AR71xx CPU initialization.  But that seemed
> kind of lame...

It does have the advantage of not requiring the user to do anything which is nice even if it's clunky looking.

--
Daniel O'Connor software and network engineer
for Genesis Software - http://www.gsoft.com.au
"The nice thing about standards is that there
are so many of them to choose from."
  -- Andrew Tanenbaum
GPG Fingerprint - 5596 B766 97C0 0E94 4347 295E E593 DC20 7B3F CE8C