svn commit: r205445 - stable/7/sys/dev/mxge

Andrew Gallatin gallatin at FreeBSD.org
Mon Mar 22 13:20:26 UTC 2010


Author: gallatin
Date: Mon Mar 22 13:20:25 2010
New Revision: 205445
URL: http://svn.freebsd.org/changeset/base/205445

Log:
  MFC 205255: Fix 2 bugs in mxge_attach()

Modified:
  stable/7/sys/dev/mxge/if_mxge.c
Directory Properties:
  stable/7/sys/   (props changed)
  stable/7/sys/cddl/contrib/opensolaris/   (props changed)
  stable/7/sys/contrib/dev/acpica/   (props changed)
  stable/7/sys/contrib/pf/   (props changed)

Modified: stable/7/sys/dev/mxge/if_mxge.c
==============================================================================
--- stable/7/sys/dev/mxge/if_mxge.c	Mon Mar 22 11:52:53 2010	(r205444)
+++ stable/7/sys/dev/mxge/if_mxge.c	Mon Mar 22 13:20:25 2010	(r205445)
@@ -4330,8 +4330,6 @@ mxge_attach(device_t dev)
 		err = ENOMEM;
 		goto abort_with_nothing;
 	}
-	taskqueue_start_threads(&sc->tq, 1, PI_NET, "%s taskq",
-				device_get_nameunit(sc->dev));
 
 	err = bus_dma_tag_create(NULL,			/* parent */
 				 1,			/* alignment */
@@ -4437,7 +4435,7 @@ mxge_attach(device_t dev)
 	err = mxge_alloc_rings(sc);
 	if (err != 0) {
 		device_printf(sc->dev, "failed to allocate rings\n");
-		goto abort_with_dmabench;
+		goto abort_with_slices;
 	}
 
 	err = mxge_add_irq(sc);
@@ -4483,6 +4481,8 @@ mxge_attach(device_t dev)
 		mxge_change_mtu(sc, mxge_initial_mtu);
 
 	mxge_add_sysctls(sc);
+	taskqueue_start_threads(&sc->tq, 1, PI_NET, "%s taskq",
+				device_get_nameunit(sc->dev));
 	callout_reset(&sc->co_hdl, mxge_ticks, mxge_tick, sc);
 	return 0;
 


More information about the svn-src-all mailing list