svn commit: r204824 - head/sys/conf

David O'Brien obrien at FreeBSD.org
Wed Mar 10 04:49:38 UTC 2010


On Tue, Mar 09, 2010 at 07:35:12PM -0700, M. Warner Losh wrote:
> 
> I'd recommend something similar to the following change:
> Index: newvers.sh
..
> +S=sys
..
> -*/sys/*)
> +*/$S/*)
>  	SRCDIR=${d##*obj}
>  	if [ -n "$MACHINE" ]; then
>  		SRCDIR=${SRCDIR##/$MACHINE}
>  	fi
> -	SRCDIR=${SRCDIR%%/sys/*}
> +	SRCDIR=${SRCDIR%%/$S/*}

Why not make it simpler as my patch did?  Do you not trust that
newvers.sh (e.g. "$0") is within the kernel directory?


> which would allow people that move sys to somewhere else to change one
> line and still have everything work.  They are going to have to make
> changes anyway to support that, since it isn't supported by FreeBSD
> out of the box.

Eh?  'svn co svn://svn.freebsd.org/base/head/sys syshead' works as-is.

Using "$0" requires no one to have to change a single line.

-- 
-- David  (obrien at FreeBSD.org)


More information about the svn-src-all mailing list