svn commit: r209226 - head/sys/fs/tmpfs

Alan Cox alc at cs.rice.edu
Wed Jun 16 16:22:05 UTC 2010


On 6/16/2010 7:43 AM, Pawel Jakub Dawidek wrote:
> On Wed, Jun 16, 2010 at 12:41:21AM +0000, Alan Cox wrote:
>    
>> Author: alc
>> Date: Wed Jun 16 00:41:21 2010
>> New Revision: 209226
>> URL: http://svn.freebsd.org/changeset/base/209226
>>
>> Log:
>>    Eliminate unnecessary page queues locking.
>>      
> [...]
>
> Could you take a look at this patch:
>
> 	http://people.freebsd.org/~pjd/patches/zfs_vnops.c.4.patch
>
>    

The patch is correct.  Go ahead and commit it.

Couldn't this function be simplified a little using uiomove_fromphys() 
instead of sf_buf_alloc() and uiomove()?  One effect would be the 
elimination of the pinning that isn't needed by amd64 (and other 
architectures that have a direct map).

Alan



More information about the svn-src-all mailing list