svn commit: r209068 - head/sys/dev/e1000

John Baldwin jhb at freebsd.org
Tue Jun 15 20:40:49 UTC 2010


On Tuesday 15 June 2010 4:18:49 pm Jack Vogel wrote:
> Ahhh, thanks for report John, will fix that asap.

I actually just tested a patch to make it use que->tq and que->task always 
instead of the rxtx_task.  I have some other patches to cleanup some of the 
taskq stuff as well, I'll send it along once I've done some testing with 
em(4).

> Jack
> 
> 
> On Tue, Jun 15, 2010 at 12:49 PM, John Baldwin <jhb at freebsd.org> wrote:
> 
> > On Friday 11 June 2010 4:54:27 pm Jack F Vogel wrote:
> > > Author: jfv
> > > Date: Fri Jun 11 20:54:27 2010
> > > New Revision: 209068
> > > URL: http://svn.freebsd.org/changeset/base/209068
> > >
> > > Log:
> > >   Add a couple fixes from Michael Tuexen.
> > >   Remove unneeded rxtx handler, make que handler generic.
> > >   Do not allocate header mbufs in rx ring if not doing hdr split.
> > >   Release the lock in rxeof call to stack.
> > >
> > >   MFC for 8.1 asap
> >
> > This causes a panic with MSIX is disabled (boot with
> > hw.pci.msix_enabled=0).
> > The reason is that in the !MSIX case, the rxtx_task is queued to the
> > adapter->tq queue, but in the MSIX case the task is queued to the per-
queue
> > que->tq queue.  igb_handle_que() assumes the MSIX case, it is not generic.
> >
> > --
> > John Baldwin
> >
> 

-- 
John Baldwin


More information about the svn-src-all mailing list