svn commit: r208811 - head/lib/libc/posix1e

Edward Tomasz Napierala trasz at FreeBSD.org
Sat Jun 5 07:40:33 UTC 2010


Author: trasz
Date: Sat Jun  5 07:40:32 2010
New Revision: 208811
URL: http://svn.freebsd.org/changeset/base/208811

Log:
  Don't use pointer to 64 bit value (id_t) to point to 32 bit value (uid_t).
  
  Found with:	Coverity Prevent
  CID:		7466, 7467
  MFC after:	2 weeks

Modified:
  head/lib/libc/posix1e/acl_to_text_nfs4.c

Modified: head/lib/libc/posix1e/acl_to_text_nfs4.c
==============================================================================
--- head/lib/libc/posix1e/acl_to_text_nfs4.c	Sat Jun  5 06:56:06 2010	(r208810)
+++ head/lib/libc/posix1e/acl_to_text_nfs4.c	Sat Jun  5 07:40:32 2010	(r208811)
@@ -50,7 +50,7 @@ format_who(char *str, size_t size, const
 	acl_tag_t tag;
 	struct passwd *pwd;
 	struct group *grp;
-	id_t *id;
+	uid_t *id;
 
 	error = acl_get_tag_type(entry, &tag);
 	if (error)
@@ -62,7 +62,7 @@ format_who(char *str, size_t size, const
 		break;
 
 	case ACL_USER:
-		id = (id_t *)acl_get_qualifier(entry);
+		id = (uid_t *)acl_get_qualifier(entry);
 		if (id == NULL)
 			return (-1);
 		/* XXX: Thread-unsafe. */
@@ -81,7 +81,7 @@ format_who(char *str, size_t size, const
 		break;
 
 	case ACL_GROUP:
-		id = (id_t *)acl_get_qualifier(entry);
+		id = (uid_t *)acl_get_qualifier(entry);
 		if (id == NULL)
 			return (-1);
 		/* XXX: Thread-unsafe. */
@@ -141,7 +141,7 @@ format_additional_id(char *str, size_t s
 {
 	int error;
 	acl_tag_t tag;
-	id_t *id;
+	uid_t *id;
 
 	error = acl_get_tag_type(entry, &tag);
 	if (error)
@@ -155,7 +155,7 @@ format_additional_id(char *str, size_t s
 		break;
 
 	default:
-		id = (id_t *)acl_get_qualifier(entry);
+		id = (uid_t *)acl_get_qualifier(entry);
 		if (id == NULL)
 			return (-1);
 		snprintf(str, size, ":%d", (unsigned int)*id);


More information about the svn-src-all mailing list