svn commit: r208717 - head/sys/fs/devfs
Jaakko Heinonen
jh at FreeBSD.org
Tue Jun 1 18:57:21 UTC 2010
Author: jh
Date: Tue Jun 1 18:57:21 2010
New Revision: 208717
URL: http://svn.freebsd.org/changeset/base/208717
Log:
Don't try to call cdevsw d_close() method when devfs_close() is called
because of insmntque1() failure.
Found with: stress2
Suggested and reviewed by: kib
Modified:
head/sys/fs/devfs/devfs_vnops.c
Modified: head/sys/fs/devfs/devfs_vnops.c
==============================================================================
--- head/sys/fs/devfs/devfs_vnops.c Tue Jun 1 18:27:48 2010 (r208716)
+++ head/sys/fs/devfs/devfs_vnops.c Tue Jun 1 18:57:21 2010 (r208717)
@@ -459,6 +459,13 @@ devfs_close(struct vop_close_args *ap)
int vp_locked, error;
/*
+ * XXX: Don't call d_close() if we were called because of
+ * XXX: insmntque1() failure.
+ */
+ if (vp->v_data == NULL)
+ return (0);
+
+ /*
* Hack: a tty device that is a controlling terminal
* has a reference from the session structure.
* We cannot easily tell that a character device is
More information about the svn-src-all
mailing list