svn commit: r210429 - in head/sys: amd64/linux32 compat/freebsd32 kern sys

Alan Cox alc at cs.rice.edu
Fri Jul 23 19:29:56 UTC 2010


Kostik Belousov wrote:
> On Fri, Jul 23, 2010 at 06:58:27PM +0000, Alan Cox wrote:
>   
>> Author: alc
>> Date: Fri Jul 23 18:58:27 2010
>> New Revision: 210429
>> URL: http://svn.freebsd.org/changeset/base/210429
>>
>> Log:
>>   Eliminate a little bit of duplicated code.
>>
>>     
> I think that amd64 copy of linux_exec_copyin_args() can go out as well.
> COMPAT_LINUX32 or linux.ko requires COMPAT_FREEBSD32, and the function
> seems to be identical to freebsd32_exec_copyin_args(), except there is
> missed check for fname != NULL.
>   

Do you want to delete it?  I would be happy for it to go away.

The reason that I was looking at this is that I'm tinkering with how we 
allocate memory for the exec strings because it accounts for > 2/3 of 
our system-wide TLB shootdowns in some workloads.



More information about the svn-src-all mailing list