svn commit: r209622 - head/sys/dev/ixgbe

[Doug Barton]

On Wed, 30 Jun 2010, Jack Vogel wrote:

> I went to a LOT of trouble setting up a mirror at home and just as I 
> went to commit the change its updated.

Not sure if you mean "mirror" literally here or not. I assume that you 
mean "local tree checked out from the master svn server."

In any case, I'm sure that we all appreciate your efforts, and the 
timing of the various commits was was unfortunate. In situations like 
this it's usually a good idea to both double check the sources, as well 
as the svn mailing list to see if someone has already gotten around to 
fixing it.

> While I understand the good intentions, please don't do this again. If 
> I had been unresponsive for days or something I understand, but its 
> been hours, and I was fixing it.

I can certainly understand your frustration here, so I'm going to (once 
again) assume (and you know what they say about that ...) that you 
didn't mean "days" literally since clearly it would not be Ok to have 
the build broken (and tinderbox error messages, etc.) for days.

In situations like this what's generally done is to respond to a 
relevant tinderbox message to the effect of "I see the problem, I'm 
working on the fix, and it should be done by $TIME." That way people 
know you're on the case and can let you do your thing in peace.

Of course, the gold standard is to test changes before committing them, 
but it's not at all uncommon to have test builds complete successfully 
under your normal working conditions but fail in the tinderbox. It even 
happened to me once ...


hth,

Doug (Ok, maybe more than once)

-- 

 	Improve the effectiveness of your Internet presence with
 	a domain name makeover!    http://SupersetSolutions.com/

 	Computers are useless. They can only give you answers.
 			-- Pablo Picasso