moving sctp to a separate directory ? (Re: svn commit: r201523 - head/sys/netinet)

Bruce Simpson bms at incunabulum.net
Tue Jan 5 13:12:48 UTC 2010


On 04/01/2010 22:23, Luigi Rizzo wrote:
> I also think that the name of the new directory or the exact percentage of
> ipv4-ness or netinet-ness of the sctp* and tcp* and multicast* stuff
> is irrelevant.  Moving directories with svn is so easy that we should not
> worry even if we need a couple of attempts to find a good name.
>    

On a related, but different, note:
     I actually think that the mcast code could have benefitted from C++ 
style templates. There's a lot of code duplication between the IPv6 and 
IPv4 versions of those modules.
     It's the entry points, and argument types, which ultimately 
mattered, so when integrating the MLD implementation into FreeBSD back 
last April, I found myself doing 'cp', 'sed', and manual edits mostly to 
deal with only *slight* semantic differences between IPv4 and IPv6 in 
the kernel.

Having said all that, it seems to me like the netinet/ code overall 
could do with being split up further into individual files, to make it 
more manageable. This has sort of already happened as time has gone on.

cheers,
BMS


More information about the svn-src-all mailing list