svn commit: r201547 - head/lib/libc/gen

[David Xu]

Alexander Kabaev wrote:
> On Tue, 05 Jan 2010 13:39:06 +0800
> David Xu <davidxu at freebsd.org> wrote:
> 
>> Alexander Kabaev wrote:
>>> Hi,
>>>
>>> some quick questions:
>>>
>>> FB10_COMPAT_PRIVATE is not used anywhere, why did it get committed?
>>> That aside, use of SYM_DEFAULT is pretty much always wrong.
>>>
>> Yes, this needs to be cleaned.
>>
>>> Also, does libthr really need to export sem_ symbols in 1.2
>>> namespace? I do not think so, but there might be reasons I am
>>> missing, could you shed some light here?
>>>
>> If libthr.so does not have 1.2 semaphore, a program linked against 
>> libthr may use 1.0 version at linking time, doesn't this cause
>> trouble? anyway, I am not symbol versioning expert, welcome to fix it.
>>
> 
> No, that won't happen. Compat (single '@') symbols are only resolvable
> at runtime, bit at link time, so ld won't see any sem_ symbols in libthr
> and by necessity will pick ones from libc.
> 
> 

My previous test got opposite result, it sticked with libthr, but this
time I tested it again, you are right, it uses version 1.2 from libc.
I will remove extra stubs from libthr.