svn commit: r203926 - in head/games/fortune: fortune strfile unstr

John Baldwin jhb at freebsd.org
Wed Feb 17 21:01:34 UTC 2010


On Wednesday 17 February 2010 1:51:33 pm Ulrich Spörlein wrote:
> On Wed, 17.02.2010 at 11:43:57 -0500, John Baldwin wrote:
> > On Monday 15 February 2010 10:10:22 am Ulrich Spoerlein wrote:
> > > Author: uqs
> > > Date: Mon Feb 15 15:10:21 2010
> > > New Revision: 203926
> > > URL: http://svn.freebsd.org/changeset/base/203926
> > > 
> > > Log:
> > >   fortune(6) switch to 3-clause BSDL; style(9)
> > >   
> > >   This reduces the diff to other *BSD and makes it possible to actually
> > >   see the code differences.
> > >   
> > >   Approved by:	ed (Co-mentor)
> > 
> > There appear to be a lot of unrelated changes to at least fortune.c in this 
> > commit.
> 
> Hi John,
> 
> care to elaborate? The commit log says that style(9) has been applied
> and it is a diff reduction commit in general.
> 
> That said, the only object code altering change is the replacing of
> exit(0) with return(0) at the end of main(). There's nothing definitive
> in style(9) about that ...

Oh, I missed the 'style(9)' bit.  A full sentence and even separate line
items such as:

- Switch to a 3-clause BSD license.
- Various style(9) fixes.

might help to reduce any confusion in the future.

-- 
John Baldwin


More information about the svn-src-all mailing list