svn commit: r216694 - head/libexec/rtld-elf

Ulrich Spörlein uqs at spoerlein.net
Tue Dec 28 13:29:45 UTC 2010


On Sat, 25.12.2010 at 08:42:38 +0000, Konstantin Belousov wrote:
> Author: kib
> Date: Sat Dec 25 08:42:38 2010
> New Revision: 216694
> URL: http://svn.freebsd.org/changeset/base/216694
> 
> Log:
>   Add a hook to pass debug flags to the build of rtld when doing make in
>   the rtld directory.
>   
>   Reviewed by:	kan

Please revert this, $(VAR) is against style, and passing DEBUG_FLAGS is
the canonical way to achieve what you wanted, eg. make DEBUG_FLAGS=-g is
working just fine for me.

> Modified:
>   head/libexec/rtld-elf/Makefile
> 
> Modified: head/libexec/rtld-elf/Makefile
> ==============================================================================
> --- head/libexec/rtld-elf/Makefile	Fri Dec 24 21:31:18 2010	(r216693)
> +++ head/libexec/rtld-elf/Makefile	Sat Dec 25 08:42:38 2010	(r216694)
> @@ -34,7 +34,7 @@ CFLAGS+=	-fPIC
>  .else
>  CFLAGS+=	-fpic
>  .endif
> -CFLAGS+=	-DPIC
> +CFLAGS+=	-DPIC $(DEBUG)
>  LDFLAGS+=	-shared -Wl,-Bsymbolic
>  DPADD=		${LIBC_PIC}
>  LDADD=		-lc_pic -lssp_nonshared


More information about the svn-src-all mailing list