svn commit: r216493 - head/sbin/geom/class/eli

[Warner Losh]

On 12/16/2010 11:54, Garrett Cooper wrote:
> On Thu, Dec 16, 2010 at 9:54 AM, David E. O'Brien<obrien at freebsd.org>  wrote:
>> Author: obrien
>> Date: Thu Dec 16 17:54:56 2010
>> New Revision: 216493
>> URL: http://svn.freebsd.org/changeset/base/216493
>>
>> Log:
>>   Revert r216473.
>>   WARNS=6 causes "warning: cast increases required alignment of target type"
>>   on arm, ia64, mips, and sparc64.
>>
>> Modified:
>>   head/sbin/geom/class/eli/Makefile
>>
>> Modified: head/sbin/geom/class/eli/Makefile
>> ==============================================================================
>> --- head/sbin/geom/class/eli/Makefile   Thu Dec 16 17:14:37 2010        (r216492)
>> +++ head/sbin/geom/class/eli/Makefile   Thu Dec 16 17:54:56 2010        (r216493)
>> @@ -11,7 +11,7 @@ SRCS+=        sha2.c
>>   DPADD= ${LIBMD} ${LIBCRYPTO}
>>   LDADD= -lmd -lcrypto
>>
>> -WARNS?=        6
>> +WARNS?=        3
>>
>>   CFLAGS+=-I${.CURDIR}/../../../../sys
>      I think it's actually safe to bump it to WARNS = 6 if you define
> NO_WCAST_ALIGN = 1, but that would need to be tested.
And the code in question needs to be audited to make sure that the 
alignment changes are benign.  Blindly setting this just papers over the 
bugs...

Warner
> Cheers,
> -Garrett
>
>
>