svn commit: r216358 - head/sys/dev/le

Tijl Coosemans tijl at
Fri Dec 10 17:06:03 UTC 2010

On Friday 10 December 2010 16:31:36 John Baldwin wrote:
> On Friday, December 10, 2010 10:05:49 am Tijl Coosemans wrote:
>> Author: tijl
>> Date: Fri Dec 10 15:05:49 2010
>> New Revision: 216358
>> URL:
>> Log:
>>   Use SYS_RES_IOPORT instead of PCIM_CMD_PORTEN when calling pci_enable_io.
>>   Approved by:	kib (mentor)
> To be honest, bus_alloc_resource() with RF_ACTIVE will set PORTEN or MEMEN for 
> you.  Drivers should no longer be calling pci_enable_io() by hand.

Looking into this, in dev/sound/pci/atiixp.c and dev/sound/pci/ich.c it
is used during resume. Can those calls be removed as well?

And in dev/mpt/mpt.c pci_enable_io and pci_disable_io are called in a
number of places. Those should probably all stay?

All other cases are during device attach with bus_alloc_resource+RF_ACTIVE
before or after.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 228 bytes
Desc: This is a digitally signed message part.
Url :

More information about the svn-src-all mailing list