svn commit: r206121 - stable/8/sys/dev/hwpmc

Fabien Thomas fabient at FreeBSD.org
Sat Apr 3 07:12:36 UTC 2010


Author: fabient
Date: Sat Apr  3 07:12:35 2010
New Revision: 206121
URL: http://svn.freebsd.org/changeset/base/206121

Log:
  MFC r205998:
  If there is multiple PMCs for the same interrupt ignore new post.
  This will indirectly fix a bug where the thread will be pinned
  forever if the assert is not compiled.

Modified:
  stable/8/sys/dev/hwpmc/hwpmc_mod.c
Directory Properties:
  stable/8/sys/   (props changed)
  stable/8/sys/amd64/include/xen/   (props changed)
  stable/8/sys/cddl/contrib/opensolaris/   (props changed)
  stable/8/sys/contrib/dev/acpica/   (props changed)
  stable/8/sys/contrib/pf/   (props changed)
  stable/8/sys/dev/xen/xenpci/   (props changed)

Modified: stable/8/sys/dev/hwpmc/hwpmc_mod.c
==============================================================================
--- stable/8/sys/dev/hwpmc/hwpmc_mod.c	Sat Apr  3 07:12:03 2010	(r206120)
+++ stable/8/sys/dev/hwpmc/hwpmc_mod.c	Sat Apr  3 07:12:35 2010	(r206121)
@@ -3972,9 +3972,11 @@ pmc_post_callchain_callback(void)
 
 	td = curthread;
 
-	KASSERT((td->td_pflags & TDP_CALLCHAIN) == 0,
-	    ("[pmc,%d] thread %p already marked for callchain capture",
-		__LINE__, (void *) td));
+	/*
+	 * If there is multiple PMCs for the same interrupt ignore new post
+	 */
+	if (td->td_pflags & TDP_CALLCHAIN)
+		return;
 
 	/*
 	 * Mark this thread as needing callchain capture.


More information about the svn-src-all mailing list