svn commit: r197654 - head/sys/dev/if_ndis

Dag-Erling Smørgrav des at des.no
Thu Oct 1 14:03:22 UTC 2009


Coleman Kane <cokane at FreeBSD.org> writes:
> Thanks, fix committed... I know style(9) says I should have not bothered
> with the commit, but the assume-that-zero-is-false logic seemed
> egregious enough at the time to warrant correcting it.

Depends.  Is ndis_80211 purely a boolean value?  If yes, it should
probably be a bit field; if no, style(9) clearly says that you should
use an explicit comparison.

(a quick perusal of the source says it isn't, so an explicit comparison
is required)

> I just corrected it improperly in my haste. Enjoy being able to
> buildkernel again. I'll be sitting in the corner.

Don't worry, you'll be in good company there :)

DES
-- 
Dag-Erling Smørgrav - des at des.no


More information about the svn-src-all mailing list