svn commit: r199552 - head/sys/dev/et

Pyun YongHyeon pyunyh at gmail.com
Thu Nov 19 22:57:16 UTC 2009


On Thu, Nov 19, 2009 at 10:41:52PM +0000, Alexey Dokuchaev wrote:
> On Thu, Nov 19, 2009 at 09:45:06PM +0000, Pyun YongHyeon wrote:
> > 
> > Modified: head/sys/dev/et/if_et.c
> > ==============================================================================
> > --- head/sys/dev/et/if_et.c	Thu Nov 19 21:39:43 2009	(r199551)
> > +++ head/sys/dev/et/if_et.c	Thu Nov 19 21:45:06 2009	(r199552)
> > @@ -76,6 +76,10 @@ MODULE_DEPEND(et, pci, 1, 1, 1);
> >  MODULE_DEPEND(et, ether, 1, 1, 1);
> >  MODULE_DEPEND(et, miibus, 1, 1, 1);
> >  
> > +/* Tunables. */
> > +static int msi_disable = 0;
> > +TUNABLE_INT("hw.re.msi_disable", &msi_disable);
> 		^^^^^
> Shouldn't it be "hw.et" instead?
> 

Oops, right.

> > +		msic = pci_msi_count(dev);
> > +		if (bootverbose)
> > +			device_printf(dev, "MSI count : %d\n", msic);
> 
> Is extra space before colon really necessary here?
> 

Not needed here.

Thanks for reviewing!

> ./danfe


More information about the svn-src-all mailing list