svn commit: r192591 - head/sys/fs/nfsserver

Bruce Evans brde at
Sat May 23 11:27:51 UTC 2009

On Fri, 22 May 2009, Sam Leffler wrote:

> Alexey Dokuchaev wrote:
>> On Fri, May 22, 2009 at 06:10:40PM +0000, Rick Macklem wrote:
>>> ...
>>> Log:
>>>   Modified the printf message of r192590 to remove the
>>>   possible DOS attack, as suggested by Sam.
>>>   -	printf("out of clientids, possible DOS attack\n");
>>> +	printf("out of clientids\n");
>> Previously, panic() message referred "nfs4", now it does not, making it
>> rather cryptic without grepping through the source code.
>> .
> I requested the printf identify the call site; e.g.
> printf("%s: out of clientids\n", __func__);

That is equally cryptic _with_ grepping through the source code, and
much uglier.  __func__ should only be used when the function name is
not a literal constant (mainly in macros).  The new nfs code only uses
__func__ in 2 places, now including this one.  The old nfs code only
uses it in a few more than 2 places.


More information about the svn-src-all mailing list