svn commit: r192059 - in head/sys: arm/at91 dev/spibus

Stanislav Sedov stas at FreeBSD.org
Wed May 13 20:25:32 UTC 2009


On Wed, 13 May 2009 18:42:49 +0000 (UTC)
Oleksandr Tymoshenko <gonzo at FreeBSD.org> mentioned:

> Author: gonzo
> Date: Wed May 13 18:42:49 2009
> New Revision: 192059
> URL: http://svn.freebsd.org/changeset/base/192059
> 
> Log:
>   - Make SPI bus bridge be non-arch dependent by using more generic
>       name
>   
>   Reviewed by:	imp
> 
> Modified:
>   head/sys/arm/at91/at91_spi.c
>   head/sys/dev/spibus/spibus.c
> 
> Modified: head/sys/arm/at91/at91_spi.c
> ==============================================================================
> --- head/sys/arm/at91/at91_spi.c	Wed May 13 18:31:28 2009	(r192058)
> +++ head/sys/arm/at91/at91_spi.c	Wed May 13 18:42:49 2009	(r192059)
> @@ -297,7 +297,7 @@ static device_method_t at91_spi_methods[
>  };
>  
>  static driver_t at91_spi_driver = {
> -	"at91_spi",
> +	"spi",
>  	at91_spi_methods,
>  	sizeof(struct at91_spi_softc),
>  };
> 
> Modified: head/sys/dev/spibus/spibus.c
> ==============================================================================
> --- head/sys/dev/spibus/spibus.c	Wed May 13 18:31:28 2009	(r192058)
> +++ head/sys/dev/spibus/spibus.c	Wed May 13 18:42:49 2009	(r192059)
> @@ -194,5 +194,5 @@ static driver_t spibus_driver = {
>  
>  devclass_t	spibus_devclass;
>  
> -DRIVER_MODULE(spibus, at91_spi, spibus_driver, spibus_devclass, 0, 0);
> +DRIVER_MODULE(spibus, spi, spibus_driver, spibus_devclass, 0, 0);
>  MODULE_VERSION(spibus, 1);
> 

On the other hand this driver appears to be machine-specific. What if one
would like to have a kernel with several SPI bus drivers included for devices
that doesn't support enumeration? In this case it will be impossible to
diffirentiate these drivers in the hints file.

-- 
Stanislav Sedov
ST4096-RIPE

!DSPAM:4a0b2cba994296549215293!




More information about the svn-src-all mailing list