svn commit: r191998 - head/sys/fs/nfsserver

Rick Macklem rmacklem at FreeBSD.org
Mon May 11 18:45:05 UTC 2009


Author: rmacklem
Date: Mon May 11 18:45:04 2009
New Revision: 191998
URL: http://svn.freebsd.org/changeset/base/191998

Log:
  	Modify nfsvno_fhtovp() to ensure that it always sets the credp
  	argument. Returning without credp set could result in a caller
  	doing crfree() on garbage.
  
  Reviewed by:	kan
  Approved by:	kib (mentor)

Modified:
  head/sys/fs/nfsserver/nfs_nfsdport.c

Modified: head/sys/fs/nfsserver/nfs_nfsdport.c
==============================================================================
--- head/sys/fs/nfsserver/nfs_nfsdport.c	Mon May 11 18:20:34 2009	(r191997)
+++ head/sys/fs/nfsserver/nfs_nfsdport.c	Mon May 11 18:45:04 2009	(r191998)
@@ -2422,6 +2422,7 @@ nfsvno_fhtovp(struct mount *mp, fhandle_
 	int error;
 	int numsecflavor, *secflavors;
 
+	*credp = NULL;
 	error = VFS_FHTOVP(mp, &fhp->fh_fid, vpp);
 	if (nam && !error) {
 		error = VFS_CHECKEXP(mp, nam, &exp->nes_exflag, credp,


More information about the svn-src-all mailing list