svn commit: r194092 - in head: sbin/geom/class/label sys/conf sys/geom/label

[Stanislav Sedov]

Hi!

There're some style errors in the file. See below.

On Sat, 13 Jun 2009 00:27:03 +0000 (UTC)
Ivan Voras <ivoras at FreeBSD.org> mentioned:

> +
> +#define	PART_CLASS_NAME	"PART"
> +#define	SCHEME_NAME	"GPT"
> +
> +#define G_LABEL_GPT_VOLUME_DIR	"gpt"
         ^^^
> +#define G_LABEL_GPT_ID_DIR	"gptid"
         ^^^

These shoule be tabs, not spaces as above.

> +
> +/* shamelessly stolen from g_part_gpt.c */
> +static void
> +sbuf_nprintf_utf16(struct sbuf *sb, uint16_t *str, size_t len)
> +{

<...>

> +	}
> +}

Why not put this function into the separate file, or turn it into inline?
This way you'll avoid code duplication.

> +	/*
> +	 * create sbuf with biggest possible size
> +	 * we need max. 4 bytes for every 2-byte utf16 char
> +	 */

Most of comments in geom code start with a capital and end up with a dot.
This one doesn't follow this rule. There're also other places.

-- 
Stanislav Sedov
ST4096-RIPE
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/svn-src-all/attachments/20090614/ff41ca76/attachment.pgp