svn commit: r193878 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

[Dmitry Morozovsky]

Kip,

On Wed, 10 Jun 2009, Kip Macy wrote:

KM> Author: kmacy
KM> Date: Wed Jun 10 01:21:32 2009
KM> New Revision: 193878
KM> URL: http://svn.freebsd.org/changeset/base/193878
KM> 
KM> Log:
KM>   As far as I can tell systems that have less than 4GB are more often hurt
KM>   by prefetched than helped.  On i386 systems and systems with less than 4GB,
KM>   prefetch is now disabled by default. I've added a prefetch enable tunable, to
KM>   enable prefetching for those systems. The prefetch disable tunable will continue
KM>   to unconditionally disable prefetching.
KM> 

[snip]

KM> +extern int zfs_prefetch_disable;
KM> +extern int zfs_prefetch_enable;

[snip]

Before the interface is not settled in stone, don't you think simple bool
zfs_prefetch tunable (defauled to what looks more reasonable to partucilar 
arch/memsize) is more clean and straightforward?


-- 
Sincerely,
D.Marck                                     [DM5020, MCK-RIPE, DM3-RIPN]
[ FreeBSD committer:                                 marck at FreeBSD.org ]
------------------------------------------------------------------------
*** Dmitry Morozovsky --- D.Marck --- Wild Woozle --- marck at rinet.ru ***
------------------------------------------------------------------------