svn commit: r191255 - in head/sys: amd64/conf conf i386/conf net
scottl at samsco.org
Tue Jun 9 18:24:35 UTC 2009
Sam Leffler wrote:
> Kip Macy wrote:
>>> I think FLOWTABLE does nto belong into DEFAULTS. Really DEFAULTS was
>>> meant for "You cannot boot without this" and if people start to weaken
>>> it, DEFAULTS will soon be the new GENERIC. That said I am not sure it
>>> belongs to GENERIC either.
>> I can either push it in to GENERIC or I can change it to NOFLOWTABLE.
>> If you want to remove it from GENERIC then we're going to have to have
>> a lengthy discussion about what most FreeBSD users actually use and
>> gut GENERIC as it stands now. The fact is, most FreeBSD users have
>> sufficiently few peers that flowtable is a win over using the routing
>> table on every lookup.
> I believe the question was mainly about mechanics, FLOWTABLE doesn't
> belong in DEFAULTS but it may well belong in GENERIC.
If you want it to be an opt-out feature, wrap the code in #ifndef
DISABLE_FLOWTABLE. I agree that what was put into DEFAULTS is
inappropriate for what DEFAULTS was meant to do.
More information about the svn-src-all