svn commit: r193752 - head/sys/dev/kbdmux

Ed Schouten ed at FreeBSD.org
Mon Jun 8 20:24:30 UTC 2009


Author: ed
Date: Mon Jun  8 20:24:29 2009
New Revision: 193752
URL: http://svn.freebsd.org/changeset/base/193752

Log:
  Use proper types in kbdmux_kbd_getc():
  
  - The return value should be a signed integer, because -1 means failure.
  - The c variable should be unsigned, to force it to be zero-extended
    when returned.
  
  Reported by:	Andreas Tobler <andreast-list fgznet ch>

Modified:
  head/sys/dev/kbdmux/kbdmux.c

Modified: head/sys/dev/kbdmux/kbdmux.c
==============================================================================
--- head/sys/dev/kbdmux/kbdmux.c	Mon Jun  8 20:08:20 2009	(r193751)
+++ head/sys/dev/kbdmux/kbdmux.c	Mon Jun  8 20:24:29 2009	(r193752)
@@ -181,10 +181,10 @@ kbdmux_kbd_putc(kbdmux_state_t *state, c
 	state->ks_inq_length++;
 }
 
-static char
+static int
 kbdmux_kbd_getc(kbdmux_state_t *state)
 {
-	char c;
+	unsigned char c;
 
 	if (state->ks_inq_length == 0)
 		return (-1);


More information about the svn-src-all mailing list