svn commit: r195851 - in head/sys/dev: e1000 ixgbe

John Baldwin jhb at freebsd.org
Fri Jul 24 17:54:51 UTC 2009


On Friday 24 July 2009 12:57:50 pm Jack F Vogel wrote:
> Author: jfv
> Date: Fri Jul 24 16:57:49 2009
> New Revision: 195851
> URL: http://svn.freebsd.org/changeset/base/195851
> 
> Log:
>   This delta fixes two bugs:
>     - When a vlan event occurs a check was not made that
>       the event was actually for the interface, thus resulting
>       in a panic. All three drivers have this vulnerability. Add
>       a check for this condition.

These are still not correct.  You need to check the softc as in the latest 
patch I sent.  Otherwise if you have multiple em(4) or igb(4) interfaces in a 
machine you will register vlan's on all the em/igb interfaces multiple times.  
E.g., if you added a em0.500 and em1.502, you would actually end up with both 
em0 and em1 doing hardware tagging for both vlans 500 and 502.

-- 
John Baldwin


More information about the svn-src-all mailing list