svn commit: r194681 - head/usr.sbin/wpa/ndis_events

Bruce Evans brde at optusnet.com.au
Wed Jul 1 13:58:07 UTC 2009


On Wed, 1 Jul 2009, Maxim Konovalov wrote:

> On Tue, 30 Jun 2009, 16:38+0200, Dag-Erling Smrgrav wrote:
>
>> Maxim Konovalov <maxim at macomnet.ru> writes:
>>> fixed, thanks.
>>
>> It still says
>>
>> static void
>> usage()
>>
>> I know this is allowed by C99, but it's not allowed by style(9).
>>
> From style(9):
>
> static void
> usage()
> {
> 	/* Insert an empty line if the function has no local variables. */
> ...
>
> Apart from the empty line, what's wrong?

style(9) hasn't been converted to its own religion yet :-).  This isn't
exactly a bug, since an old-style Standard C function definition is
still Normal for usage().  Normal file order is a prototype for usage(),
then main() calling usage(), then usage(), so a separate prototype for
usage() is Normal.  Then usage an old-style definition for usage() breaks
K&R support without affecting Standard C support.

Bruce


More information about the svn-src-all mailing list