svn commit: r187069 - stable/7/sbin/fsck_ffs

[Xin LI]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi, David,

David O'Brien wrote:
> On Mon, Jan 12, 2009 at 12:39:22AM +0000, Xin LI wrote:
>> Author: delphij
>> Date: Mon Jan 12 00:39:22 2009
>> New Revision: 187069
>> URL: http://svn.freebsd.org/changeset/base/187069
>>
>> Log:
>>   MFC revisions 178088 and 179656: Catastrophic recovery mode.
> 
> Hi Xin,
> I guess you missed my email to you about this.  I was hoping to get an
> answer to this before it was MFC'ed.

Oops, sorry about that, I think I must have missed the e-mail...

> The use of 'C' conflicts with a Juniper Networks change Juniper wants to
> push back to FreeBSD.  
> 
> For Juniper the -C flag is the "clean" flag.  Meaning don't do anything
> if the FS is clean, other wise do as full a fsck as possible (vs. just
> a "preen" fsck).  It is useful as 'fsck -C -y /var' (for instance).
> 
> Do you think your functionality could live under the "-D" (damaged)
> option?  fsck_ffs already had a "-c" option, or Juniper would have
> used that letter.

I'm fine with a rename of the option, 'D' sounds a reasonable for my
functionality.  I have used uppercase to imply that the option is
potentially dangerous.

One bikeshed candidate: For non-native English speakers, flag 'p' sounds
somewhat vague, and 'C' is not quite straightforward either, at the
first glance, 'preen' seems to be stronger than 'clean'.  Perhaps, 'P'
would be a better candidate (a stronger 'preen') for the proposed
functionality, just my $0.02 :)

Cheers,
- --
Xin LI <delphij at delphij.net>	http://www.delphij.net/
FreeBSD - The Power to Serve!
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.10 (FreeBSD)

iEYEARECAAYFAklxriYACgkQi+vbBBjt66DwqACfWbN4XfBUcuMalw5MtuxtoeI5
V0gAoLOT/nOy6t5Vy9cP7qqv3VmZtDx9
=0lpr
-----END PGP SIGNATURE-----