svn commit: r186504 - head/sbin/mount

[David O'Brien]

On Mon, Jan 12, 2009 at 10:44:25AM +0100, Christoph Mallon wrote:
> David O'Brien schrieb:
>> On Sun, Jan 11, 2009 at 08:56:22AM +0100, Christoph Mallon wrote:
>>> David O'Brien schrieb:
>>>> On Sun, Jan 04, 2009 at 07:06:18PM +0100, Christoph Mallon wrote:
>>>>> I'm pretty sure $SUPERNATURAL_BEING_OF_YOUR_CHOICE killed a kitten for 
>>>>> the ugly hack you added to mount. The moment you overflow a buffer, you 
>>>>> are in no man's land and there's no escape. I appended a patch, which 
>>>>> solves this issue once and for all: The argv array gets dynamically 
>>>>> expanded, when its limit is reached.
>>>>> Please - for all kittens out there - commit this patch.
>>>> Hi Christoph,
>>>> Unfortunately your patch doesn't work.
>>>> For a 'ufs' file system listed in /etc/fstab
>>>>     $ umount /foo
>>>>     $ mount /foo
>>>> Does not work.
>>> Why haven't you told me earlier?
>> Wow, wish I did have the gift to know something before I know something.
>> Especially tomorrow's lotto #'s. ;-)
> 
> I sent you my patch almost a week before you commited your changes. I 
> think, there was enough time to tell me, that my patch had a flaw. 

Christoph when I work for you for $$, then you can be demanding on when
I read email and test the attached patches.  Since this is in my free
time...

> I've attached a corrected version of my patch, which has a mnt_argc = 0; 
> added in order to reset the argument vector on reentry of mountfs() 
> (instead of appending to the arguments of the last round).

If you want me to read your patches - stop making larger changes than
necessary - that primarily undo the changes I've already done.  Instead
send patches that fix bugs you find in smaller ways (unless that's not
possible).

thanks,
-- 
-- David  (obrien at FreeBSD.org)
Q: Because it reverses the logical flow of conversation.
A: Why is top-posting (putting a reply at the top of the message) frowned upon?
Let's not play "Jeopardy-style quoting"