svn commit: r189052 - head/sys/dev/drm

[Ed Schouten]

* Robert Noland <rnoland at FreeBSD.org> wrote:
> On Wed, 2009-02-25 at 20:42 +0100, Ed Schouten wrote:
> > Hi Robert,
> > 
> > * Robert Noland <rnoland at FreeBSD.org> wrote:
> > > +static struct drm_msi_blacklist_entry drm_msi_blacklist[] = {
> > > +	{0x8086, 0x2772}, /* Intel i945G	*/ \
> > > +	{0x8086, 0x27A2}, /* Intel i945GM	*/ \
> > > +	{0x8086, 0x27AE}, /* Intel i945GME	*/ \
> > > +	{0, 0}
> > > +};
> > 
> > Wouldn't it be better to use PCI_VENDOR_INTEL/PCI_PRODUCT_INTEL_*
> > definitions here?
> 
> Where are those located?  The rest of drm just uses the hex id's, if
> there is a better way, I'm up for it.

Oh wait, I always thought they were part of some kind of central list,
like usbdevs, but it turns out device drivers just #define them
themselves. Never mind.

-- 
 Ed Schouten <ed at 80386.nl>
 WWW: http://80386.nl/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/svn-src-all/attachments/20090225/09394483/attachment.pgp