svn commit: r200422 - head/sys/dev/vge

Pyun YongHyeon yongari at FreeBSD.org
Fri Dec 11 16:06:44 PST 2009


Author: yongari
Date: Sat Dec 12 00:06:43 2009
New Revision: 200422
URL: http://svn.freebsd.org/changeset/base/200422

Log:
  Remove driver lock assertion in MII register access. This change
  was made in r199543 to remove MTX_RECURSE. These routines can be
  called in device attach phase(e.g. mii_phy_probe()) so checking
  assertion here is not right as caller does not hold a driver lock.

Modified:
  head/sys/dev/vge/if_vge.c

Modified: head/sys/dev/vge/if_vge.c
==============================================================================
--- head/sys/dev/vge/if_vge.c	Fri Dec 11 23:52:42 2009	(r200421)
+++ head/sys/dev/vge/if_vge.c	Sat Dec 12 00:06:43 2009	(r200422)
@@ -378,7 +378,6 @@ vge_miibus_readreg(dev, phy, reg)
 	if (phy != (CSR_READ_1(sc, VGE_MIICFG) & 0x1F))
 		return(0);
 
-	VGE_LOCK_ASSERT(sc);
 	vge_miipoll_stop(sc);
 
 	/* Specify the register we want to read. */
@@ -417,7 +416,6 @@ vge_miibus_writereg(dev, phy, reg, data)
 	if (phy != (CSR_READ_1(sc, VGE_MIICFG) & 0x1F))
 		return(0);
 
-	VGE_LOCK_ASSERT(sc);
 	vge_miipoll_stop(sc);
 
 	/* Specify the register we want to write. */


More information about the svn-src-all mailing list