svn commit: r196451 - head/sys/netinet/ipfw
Christoph Mallon
christoph.mallon at gmx.de
Sun Aug 23 15:10:53 UTC 2009
Bruce Evans schrieb:
> % */
> % int
> % ipfw_init(void)
> % {
> % int error = 0;
>
> This variable is not really used.
>
> Initialization in declaration. This mainly obfuscates the non-use of the
> variable.
Rather the opposite is true:
void f(void)
{
int error = 0; // GCC warns that error is unused
}
void g(void)
{
int error;
error = 0; // GCC is silent
}
In this case it does not help, because error is used. But an assignment
halfway down the function definitely would not improve the situation.
Christoph
More information about the svn-src-all
mailing list