svn commit: r195960 - in head/sys/dev/usb: . controller input
rwatson at FreeBSD.org
Mon Aug 3 18:46:26 UTC 2009
On Mon, 3 Aug 2009, Hans Petter Selasky wrote:
> On Monday 03 August 2009 19:46:16 Bruce Evans wrote:
>> On Mon, 3 Aug 2009, M. Warner Losh wrote:
>>> In message: <200908030827.21108.hselasky at c2i.net>
>>> : I see two solutions:
>>> : 1) Disable the timekeeping if no keys are pressed.
>>> : 2) Second option is to use getmicrotime. Actually what I need is just a
>>> : millisecond time reference so I know when to repeat the last key.
>>> : Any opinions? DELAY() or getmicrotime() ?
>> DELAY(1) is somewhet usable.
> I think DELAY(1) is not accurate enough.
> I suggest that the DELAY(1000) is only active while a key is actually
> See attached patch. Please test and report back.
This seems a reasonable middle ground -- avoids use of sensitive time counters
in DDB, avoids expensive poll operation most of the time, and allows key
repeat to work, which is especially nice for backspace in DDB. :-)
More information about the svn-src-all