svn commit: r191353 - in releng/7.2/contrib/ntp: . ntpq
Colin Percival
cperciva at FreeBSD.org
Tue Apr 21 10:54:48 UTC 2009
Author: cperciva
Date: Tue Apr 21 10:54:47 2009
New Revision: 191353
URL: http://svn.freebsd.org/changeset/base/191353
Log:
MFH r191302: Fix a buffer overflow.
For reasons of stack alignment, it does not appear that this is exploitable
on any systems FreeBSD runs on, so this will not be getting a security
advisory.
Approved by: re (kib)
Modified:
releng/7.2/contrib/ntp/ (props changed)
releng/7.2/contrib/ntp/ntpq/ntpq.c
Modified: releng/7.2/contrib/ntp/ntpq/ntpq.c
==============================================================================
--- releng/7.2/contrib/ntp/ntpq/ntpq.c Tue Apr 21 10:51:22 2009 (r191352)
+++ releng/7.2/contrib/ntp/ntpq/ntpq.c Tue Apr 21 10:54:47 2009 (r191353)
@@ -3185,9 +3185,9 @@ cookedprint(
if (!decodeuint(value, &uval))
output_raw = '?';
else {
- char b[10];
+ char b[12];
- (void) sprintf(b, "%03lo", uval);
+ (void) snprintf(b, sizeof(b), "%03lo", uval);
output(fp, name, b);
}
break;
More information about the svn-src-all
mailing list