svn commit: r190919 - in head/sys: amd64/amd64 amd64/include i386/i386 i386/include

[Alexander Kabaev]

On Sat, 11 Apr 2009 09:35:28 -0700
Steve Kargl <sgk at troutmask.apl.washington.edu> wrote:

> On Sat, Apr 11, 2009 at 02:01:01PM +0000, Ed Schouten wrote:
> > Author: ed
> > Date: Sat Apr 11 14:01:01 2009
> > New Revision: 190919
> > URL: http://svn.freebsd.org/changeset/base/190919
> > 
> > Log:
> >   Simplify in/out functions (for i386 and AMD64).
> >   
> >   Remove a hack to generate more efficient code for port numbers
> > below 0x100, which has been obsolete for at least ten years,
> > because GCC has an asm constraint to specify that.
> >   
> >   Submitted by:	Christoph Mallon <christoph mallon gmx de>
> > 
> 
> I thought Christoph and bde were still hashing out the correctness
> of this patch.
> 
> http://lists.freebsd.org/pipermail/freebsd-amd64/2009-April/012064.html
> 
> -- 
> Steve

The patch is inconsistent in regards to usage of volatile vs.
__volatile even within itself. I think the code is sloppy and was not
ready to be committed yet. Please fix or back out.

-- 
Alexander Kabaev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/svn-src-all/attachments/20090411/c7a3b794/signature.pgp