svn commit: r190849 - head/sys/geom/part

[Max Laier]

On Wednesday 08 April 2009 18:18:17 Marcel Moolenaar wrote:
> Author: marcel
> Date: Wed Apr  8 16:18:16 2009
> New Revision: 190849
> URL: http://svn.freebsd.org/changeset/base/190849
>
> Log:
>   Don't use hexadecimal in the EBR partition names, because 'a'..'f'
>   are more commonly known as BSD partition names.
>
>   Discussed with: ivoras@
>
> Modified:
>   head/sys/geom/part/g_part_ebr.c
>
> Modified: head/sys/geom/part/g_part_ebr.c
> ===========================================================================
>=== --- head/sys/geom/part/g_part_ebr.c	Wed Apr  8 16:12:28 2009	(r190848)
> +++ head/sys/geom/part/g_part_ebr.c	Wed Apr  8 16:18:16 2009	(r190849) @@
> -344,7 +344,7 @@ g_part_ebr_name(struct g_part_table *tab
>      char *buf, size_t bufsz)
>  {
>
> -	snprintf(buf, bufsz, "+%08x", entry->gpe_index);

Not to bikeshed, but why not use "+%08X" instead?

> +	snprintf(buf, bufsz, "+%08u", entry->gpe_index);
>  	return (buf);
>  }
>
>
>
> !DSPAM:49dcce6b450631134040011!

-- 
/"\  Best regards,                      | mlaier at freebsd.org
\ /  Max Laier                          | ICQ #67774661
 X   http://pf4freebsd.love2party.net/  | mlaier at EFnet
/ \  ASCII Ribbon Campaign              | Against HTML Mail and News