svn commit: r184379 - head/lib/libcam
Marius Strobl
marius at FreeBSD.org
Mon Oct 27 14:46:58 PDT 2008
Author: marius
Date: Mon Oct 27 21:46:58 2008
New Revision: 184379
URL: http://svn.freebsd.org/changeset/base/184379
Log:
Supply a valid Connect ID when issuing XPT_DEV_MATCH, which
according to my reading of the CAM draft is mandatory for
all CCB function calls and enforced by xptioctl() since at
least r168752. Previously we happened to use 0 as the Path
ID, causing the XPT_DEV_MATCH call to fail if there's no
SCSI bus 0. Basically the same bug was also fixed the same
way for camcontrol(8) as part of r126514.
PR: 127605
Submitted by: Eygene Ryabinkin
Approved by: silence from ken and scottl
MFC after: 1 week
Modified:
head/lib/libcam/camlib.c
Modified: head/lib/libcam/camlib.c
==============================================================================
--- head/lib/libcam/camlib.c Mon Oct 27 21:45:18 2008 (r184378)
+++ head/lib/libcam/camlib.c Mon Oct 27 21:46:58 2008 (r184379)
@@ -346,6 +346,9 @@ cam_open_btl(path_id_t path_id, target_i
bzero(&ccb, sizeof(union ccb));
ccb.ccb_h.func_code = XPT_DEV_MATCH;
+ ccb.ccb_h.path_id = CAM_XPT_PATH_ID;
+ ccb.ccb_h.target_id = CAM_TARGET_WILDCARD;
+ ccb.ccb_h.target_lun = CAM_LUN_WILDCARD;
/* Setup the result buffer */
bufsize = sizeof(struct dev_match_result);
More information about the svn-src-all
mailing list