svn commit: r185356 - head/sys/dev/ixgbe

Sam Leffler sam at freebsd.org
Thu Nov 27 10:35:54 PST 2008


Ivan Voras wrote:
> 2008/11/27 Dag-Erling Smørgrav <des at des.no>:
>   
>> "Ivan Voras" <ivoras at gmail.com> writes:
>>     
>>> And at least the newer GEOM code also uses c99 variable declarations
>>> (not only for initializers - they were c99 from the start).
>>>       
>> I'm curious about what you mean with "c99 variable declarations".  If
>> you are referring to loop variable declarations, I can only find two
>> cases, both in g_linux_lvm.c.  Other than that and mixing declarations
>> with statements (which style(9) explicitly forbids), there is no
>> difference between c89 to c99 as far as variable declarations are
>> concerned.
>>     
>
> Yes, but not only loops - I mean things like:
>
> if () {
>   struct *something abc;
>   int y;
>   ...
> }
>
> You'll probably find my code is one the biggest users of this style
> but I've only started using it when I saw it already used.
>
>   

Repeat after me: "style is a guideline and not a contract".

    Sam




More information about the svn-src-all mailing list